Add allow-popups and allow-modals to the preview sandbox
#951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @gunstonej would you like to test this change on the Binder preview? https://mybinder.org/v2/gh/jtpio/voila/allow-popups?urlpath=lab popups-preview.mp4 |
@jtpio - just checked it and looks good 👍 - thanks very much! |
|
Great, thanks for trying it out 👍 I think we can get this change in the preview extension so it matches the behavior when rendered in Voila directly. |
jtpio
changed the title
allow-popups and allow-modals to the preview sandbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #931 (comment)
Code changes
Add
allow-popupsandallow-modalsto the JupyterLab Preview IFrame sandbox.User-facing changes
Users can display popups in the JupyterLab preview.
Backwards-incompatible changes
None