Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong base_url #993

Merged
merged 1 commit into from Oct 5, 2021
Merged

Conversation

trungleduc
Copy link
Member

Close #992

@trungleduc
Copy link
Member Author

@jtpio can we re-release 0.3.0a0 with this pass?

@jtpio
Copy link
Member

jtpio commented Oct 5, 2021

@jtpio can we re-release 0.3.0a0 with this pass?

We can release 0.3.0a1 it's fine 👍

@jtpio
Copy link
Member

jtpio commented Oct 5, 2021

Looks like there is an ongoing issue with GitHub Actions at the moment (checks are not triggered):

image

@jtpio jtpio added this to the 0.3.0 milestone Oct 5, 2021
@jtpio jtpio added the bug Something isn't working label Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb
Render
chromium
actual 4817 <- [5048 - 5580 - 6664] -> 9974 4074 <- [4252 - 4501 - 5127] -> 6724 3938 <- [4070 - 4272 - 4532] -> 5282 3760 <- [4108 - 4133 - 4185] -> 4367 2701 <- [2752 - 2785 - 2976] -> 3227 15714 <- [18651 - 23581 - 33360] -> 62539 11747 <- [13906 - 16094 - 16146] -> 16388 14118 <- [14242 - 14363 - 14409] -> 14500 1725 <- [1764 - 1853 - 1917] -> 2033
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2021-10-05 15:32:26.468263698 +0000
+++ /dev/fd/62	2021-10-05 15:32:26.468263698 +0000
@@ -8,27 +8,27 @@
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v4",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
         "l2": 524288,
-        "l3": 52428800
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "79",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.3,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "1",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.8.0-1042-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "487dcaac68944409a00596acdb9a6fc0",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc
Copy link
Member Author

It works now on Binder

bug.mp4

@jtpio
Copy link
Member

jtpio commented Oct 5, 2021

Nice.

I was wondering why we didn't have the Binder link posted on new PRs anymore, but that is because the benchmark workflow overwrites it:

image

@jtpio
Copy link
Member

jtpio commented Oct 5, 2021

I was wondering why we didn't have the Binder link posted on new PRs anymore, but that is because the benchmark workflow overwrites it:

I was wondering why we didn't have the Binder link posted on new PRs anymore, but that is because the benchmark workflow overwrites it:

Tracked in #994

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit e99355f into voila-dashboards:main Oct 5, 2021
@trungleduc trungleduc deleted the bugfix/wrong-base-url branch October 5, 2021 16:12
@jtpio
Copy link
Member

jtpio commented Oct 5, 2021

Looks like there is an ongoing issue with GitHub Actions at the moment (checks are not triggered):

Let's wait a bit before making the release as there still seems to be issues on GitHub side.

@trungleduc
Copy link
Member Author

@jtpio it looks like GHA returned to normal now, we can cut a new alpha ?

@jtpio
Copy link
Member

jtpio commented Oct 6, 2021

Sure. Was waiting for #996 but a couple of tests seem to be failing (probably flaky)

@trungleduc
Copy link
Member Author

I think there is some real problems with my tests, I drafted #996 to fix it.

@jtpio
Copy link
Member

jtpio commented Oct 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of the base_url in 0.3.0a0
2 participants