Padding, positioning, and event emitting additions/enhancements #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduces 2 new properties - `row._renderedContent.contentHeight` which will be the actual content size of the cell - `column. headerPadding` which can be used to set the padding for the header separately from the body - Adds `bottomMargin` to the bottom of the table. - Fixes borders so they look more like a table
…ounds * Added a 'pos' attribute to control the table positioning within the document * Incorporated padding fixes from MichielDeMey's fork with recommended fix requested in his PR * Sending the row index through to the onRowAdd and onCellBackgroundAdd event emitters * Passing the padding.right value to the custom renderer
|
Nice, glad you fixed the outstanding issue from my PR. 👍 |
|
Integrated in 0.4.0 release. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great work on this library. It really helped out on a project of ours recently.
Our PDF's required some fairly customized formatting, so I had to fork this repo to add in some needed functionality, and I thought I should submit a PR in case you think some or all of it would be a welcome addition.
Here's the summary of my changes:
Sorry to have all this wrapped into a single PR.
Let me know if you have any questions about any of it, or would like any changes made.
For reference, I've added a couple of screenshots of the layouts we were able to achieve with these changes in place.
Thanks again for the great work :)
