Save without annoying pop up dialog

… now that we have fileSystemWrite permission implemented
vojtajina · Jun 29, 2012 · d8cb963 · d8cb963
1 parent 5476262
commit d8cb963
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/app/js/services/tabs.js b/app/js/services/tabs.js
@@ -92,7 +92,7 @@ TD.factory('tabs', function(editor, fs, log, Tab, chromeFs, lru, settings, $root
     }
 
     if (tab.file) {
-      chromeFs.getWritableFileEntry(tab.file, saveFile);
+      saveFile(tab.file);
     } else {
       chromeFs.chooseFile({type: "saveFile"}, saveFile);
     }
@@ -106,9 +106,6 @@ TD.factory('tabs', function(editor, fs, log, Tab, chromeFs, lru, settings, $root
         return;
       }
 
-      // TODO(vojta): remove this hack when fixed in chrome
-      tab._hasWritePermission = true;
-
       fs.saveFile(writableFileEntry, tab.session.getValue()).then(function() {
         tab.setFileEntry(writableFileEntry);
       });
@@ -120,18 +117,14 @@ TD.factory('tabs', function(editor, fs, log, Tab, chromeFs, lru, settings, $root
     }
 
     if (tab.file) {
-      if (tab._hasWritePermission) {
-        saveFile(tab.file);
-      } else {
-        chromeFs.getWritableFileEntry(tab.file, saveFile);
-      }
+      saveFile(tab.file);
     } else {
       chromeFs.chooseFile({type: "saveFile"}, saveFile);
     }
   };
 
   tabs.open = function() {
-    chromeFs.chooseFile({type: 'openFile'}, function(fileEntry) {
+    chromeFs.chooseFile({type: 'openWritableFile'}, function(fileEntry) {
       if (!fileEntry) {
         return;
       }

diff --git a/app/manifest.json b/app/manifest.json
@@ -23,7 +23,8 @@
     "clipboardWrite",
     "unlimitedStorage",
     "storage",
-    "fileSystem"
+    "fileSystem",
+    "fileSystemWrite"
   ],
   "intents": {
     "http://webintents.org/edit": [