Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uploading files via ajax in Safari 11 #155

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

Ciki
Copy link
Contributor

@Ciki Ciki commented Apr 17, 2018

before form submission, clone form and remove empty file inputs as these causes Safari 11 to stall

https://stackoverflow.com/questions/49672992/ajax-request-fails-when-sending-formdata-including-empty-file-input-in-safari

@PavelJurasek
Copy link

I was just investigating the issue with 503 response when submitting ajax form in Safari. I just tested it and it works like a charm 🙏

@Ciki
Copy link
Contributor Author

Ciki commented Apr 17, 2018

hah, spent couple of hours to hunt it down and fix. glad you didn't have to :)

target this fix for Safari 11 only where the bug is actually present
@Ciki
Copy link
Contributor Author

Ciki commented Apr 18, 2018

@PavelJurasek I updated the changes as the original did not copy dynamic form values like select or textarea values due jquery.clone() implementation. it should work flawlessly now.

@vojtech-dobes vojtech-dobes merged commit 638d3cf into vojtech-dobes:master Apr 18, 2018
@vojtech-dobes
Copy link
Owner

Thanks!

zipper added a commit to zipper/nette.ajax.js that referenced this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants