Support for Jakarta JSONB version 2 #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmannibucau you are the author of original implementation so if you want to comment I will leave this PR open for a week. |
|
Works for me. I'd just mention i tend to use maven shade plugin relocation to do it and a dedicated module but it is an impl detail, no user impact so let's go. |
|
Thanks you. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Jakarta JSON bind version 2. To have support for both version 1 and version 2 it was needed to use
javax.json.bind:javax.json.bind-apidependency for version 1 andjakarta.json.bind:jakarta.json.bind-apifor version 2.I didn't want to copy&paste implementation so I changed
JsonbParserto support both versions at the same time. AlsoJsonbParserTestis reused. It was updated for Jakarta and is copied in build time with replacedjakarta.json.bindimports tojavax.json.bind. (It is done in a similar way as support for JAX-RS version 2 (javax) and version 3 (jakarta) inJaxrsApplicationParser.)