Clean up some analyzer warnings and mark a method that can return nil #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vokal-isaac
reviewed
Nov 11, 2016
| [self.collectionView moveItemAtIndexPath:indexPath toIndexPath:newIndexPath]; | ||
| if (newIndexPath) { | ||
| [self.collectionView moveItemAtIndexPath:indexPath toIndexPath:newIndexPath]; | ||
| } |
There was a problem hiding this comment.
Would it make sense to test newIndexPath at the top of the NSFetchedResultsChangeMove case? It's being used in various tests outside of these checks as it is.
There was a problem hiding this comment.
Yeah, you're right. I thought it would still need to execute the case on line 285, but that's not true after all.
vokal-isaac
reviewed
Nov 11, 2016
| if (newIndexPath) { | ||
| [self.collectionView moveItemAtIndexPath:indexPath toIndexPath:newIndexPath]; | ||
| } | ||
| [self.collectionView moveItemAtIndexPath:indexPath toIndexPath:newIndexPath]; |
There was a problem hiding this comment.
Should this case execute if newIndexPath is nil?
| if (newIndexPath) { | ||
| [self.collectionView moveItemAtIndexPath:indexPath toIndexPath:newIndexPath]; | ||
| } | ||
| [self.collectionView moveItemAtIndexPath:indexPath toIndexPath:newIndexPath]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just nil checks.
Fixes #107.
@vokal/ios-developers cool?