Modernize all the syntax!! #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of defaulting to SQLite
in unit tests
…rmatting # Conflicts: # Paging Data Source Example/Core Data/Data Sources/VOKPlayerDataSource.h # Paging Data Source Example/VOKPagingViewController.h # Pod/Classes/VOKCoreDataManager.m # SampleProject/DataSource/VOKPersonDataSource.h # SampleProject/Models/VOKMappablePerson.h # SampleProject/VOKCoreDataManagerTests/CoreDataManagerDeleteTests.m # SampleProject/VOKCoreDataManagerTests/ManagedObjectImportExportTests.m # SampleProject/VOKViewController.h
| @@ -223,24 +223,24 @@ - (void)tableView:(UITableView *)tableView didDeselectRowAtIndexPath:(NSIndexPat | |||
|
|
|||
| - (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView | |||
| { | |||
| NSInteger sectionCount = [[_fetchedResultsController sections] count]; | |||
| NSInteger sectionCount = _fetchedResultsController.sections.count; | |||
There was a problem hiding this comment.
Does this still need to access the _fetchedResultsController or can it grab self.fetchedResultsController?
There was a problem hiding this comment.
I can probably make it work as a property
| @@ -188,7 +188,7 @@ - (void)initPersistentStoreCoordinator | |||
| self.migrationFailureOptions == VOKMigrationFailureOptionWipeRecovery) { | |||
| VOK_CDLog(@"Full database delete and rebuild"); | |||
| [[NSFileManager defaultManager] removeItemAtPath:storeURL.path error:nil]; | |||
| if (
There was a problem hiding this comment.
although, how often to we have store types than than SQLite?
There was a problem hiding this comment.
Just about never, which is why nobody noticed this
| - (NSFetchedResultsController *)fetchedResultsController | ||
| { | ||
| if (!_fetchedResultsController) { | ||
| [self initFetchedResultsController]; |
There was a problem hiding this comment.
Without this lazy-loader, is initFetchedResultsController being called somewhere else?
There was a problem hiding this comment.
yes, the init method
|
Cool, LGTM |
|
@designatednerd, what say you? |
|
|
designatednerd
added a commit
that referenced
this pull request
Nov 4, 2015
Modernize all the syntax!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
dispatch_async@vokal/ios-developers, want to look at some dot syntax?