Specify locale to ensure ISO 8601 date formatters work as expected #81
Conversation
…egardless of user's selected calendar See https://developer.apple.com/library/mac/qa/qa1480/_index.html
|
LGTM, do you think it's worth adding a test for this? |
|
Probably, but don't have time to do so right now. Feel like taking a crack at it? |
|
sure |
Add test for date formatter locale
|
@chillpop's test has been merged. Anyone else want to have a look, @vokal/ios-developers? |
|
Oh wait, one more thing: I'll do a bugfix release for this. |
|
I take that back: updating the version number in the podspec means cascading updates to the pods directory in the sample projects, so I'll open another PR for that after this one is merged. |
| @@ -57,6 +57,7 @@ + (NSDateFormatter *)vok_defaultDateFormatter | |||
| DefaultDateFormatter = [NSDateFormatter new]; | |||
| DefaultDateFormatter.dateFormat = @"yyyy-MM-dd'T'HH:mm:ss.SSSSSS'Z'"; | |||
| DefaultDateFormatter.timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0]; | |||
| DefaultDateFormatter.locale = [NSLocale localeWithLocaleIdentifier:@"en_US_POSIX"]; | |||
There was a problem hiding this comment.
Would it make sense to make a constant out of this string literal in the .h file? That way it can be shared here and in tests?
|
Neato. |
|
@brockboland This would make a great show & tell at the next NSCoder |
|
@bryanluby good points |
|
Updated |
|
LGTM |
| VOKDefaultDateFormatterLocaleIdentifier); | ||
| XCTAssertEqualObjects([VOKManagedObjectMap vok_dateFormatterWithoutMicroseconds].locale.localeIdentifier, | ||
| VOKDefaultDateFormatterLocaleIdentifier); | ||
| } |
There was a problem hiding this comment.
My instinct is that it'd be better to test the output of the date formatter when applied to various date strings with various current locales, but I'm not sure offhand how to set the current locale programmatically for testing.
There was a problem hiding this comment.
AFAIK, you can only set the locale by passing in process arguments or choosing a locale in the Xcode scheme:
https://developer.apple.com/library/ios/documentation/MacOSX/Conceptual/BPInternational/TestingYourInternationalApp/TestingYourInternationalApp.html
http://useyourloaf.com/blog/using-launch-arguments-to-test-localizations/
Which makes testing that way a bit of a pain.
There was a problem hiding this comment.
Unless we move this test to a new test target and add a scheme specifically for it. I haven't done any testing to figure out what region or locale we could use for this that would change the calendar. You can switch it in Settings > General > Language & Region > Calendar.
There was a problem hiding this comment.
Sounds like more trouble than it's worth, then.
|
@vokal-isaac good to pull, then? |
|
(:goat:,) |
|
thanks! |
See https://developer.apple.com/library/mac/qa/qa1480/_index.html
@vokal/ios-developers quick one