Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use in app extensions #94

Merged
merged 5 commits into from
Oct 4, 2016

Conversation

chillpop
Copy link
Contributor

@chillpop chillpop commented Oct 3, 2016

To allow Vokoder to be used in app extensions, some small parts had to be removed. Specifically, the parts that call [UIApplication sharedApplication] and UIAlertView/UIAlertController. To achieve this, I added a new subspace that handles the nitty gritty of adding a new preprocessor definition that we can use. (Apple did not expose any way that I can tell to alert the compiler that it is compiling for an app extension.) Without this, Vokoder would fail to build when included in an app extension target.

I added a new today extension target that will be built on Travis to verify that there are no errors. (Thus the giant diff.)

@brockboland, @vokal-isaac, @bryanluby, @designatednerd code review?

@chillpop
Copy link
Contributor Author

chillpop commented Oct 4, 2016

Looks like I need to add some tests for the new target to make Travis happy.

@chillpop
Copy link
Contributor Author

chillpop commented Oct 4, 2016

Change of plans: build the Today Widget target along with the main sample app target.

@brockboland
Copy link
Contributor

@chillpop are you using VOKMigrationFailureOptionWipeRecoveryAndAlert in your project?

@seanwolter @designatednerd @vokal-isaac @bryanluby quick poll: has anyone ever used VOKMigrationFailureOptionWipeRecoveryAndAlert on a project? Can we just remove it? It seems unlikely that many projects would tell the user about this error, particularly with a non-localized alert. Removing it would complicate release versioning on the 3.x branch, to be sure, but this seems like an unnecessary workaround for a feature that probably isn't used.

@chillpop
Copy link
Contributor Author

chillpop commented Oct 4, 2016

I've never used it. I really like that idea.

@brockboland
Copy link
Contributor

Looks like that option was originally added in vokal/VOKCoreDataManager@82f8d8c, maybe written by @MattFoley? Commit message is unclear.

Hey @MattFoley: do you still use this, and if so, do you still use VOKMigrationFailureOptionWipeRecoveryAndAlert?

@chillpop
Copy link
Contributor Author

chillpop commented Oct 4, 2016

🕵️ @brockboland

@bryanluby
Copy link
Contributor

@brockboland I have not used it

@MattFoley
Copy link

Used it for years, although on a slightly modified branch of the original CoreDataManager-iOS repository.

@MattFoley
Copy link

Oh sorry, never mind, I just used the wipe silently option.

@MattFoley
Copy link

Feel free to remove it, I'm spending all my days in React Native lately, no more Core Data stuggles.

@brockboland
Copy link
Contributor

Groovy, thanks @MattFoley!

@brockboland
Copy link
Contributor

LGTM

@brockboland brockboland merged commit 05f99be into vokal:swift2 Oct 4, 2016
@chillpop chillpop deleted the feature/app-extension branch April 26, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants