-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use in app extensions #94
Conversation
to avoid a regression when linting in cocoapods 1.0
Looks like I need to add some tests for the new target to make Travis happy. |
Change of plans: build the Today Widget target along with the main sample app target. |
@chillpop are you using @seanwolter @designatednerd @vokal-isaac @bryanluby quick poll: has anyone ever used |
I've never used it. I really like that idea. |
Looks like that option was originally added in vokal/VOKCoreDataManager@82f8d8c, maybe written by @MattFoley? Commit message is unclear. Hey @MattFoley: do you still use this, and if so, do you still use |
🕵️ @brockboland |
@brockboland I have not used it |
Used it for years, although on a slightly modified branch of the original CoreDataManager-iOS repository. |
Oh sorry, never mind, I just used the wipe silently option. |
Feel free to remove it, I'm spending all my days in React Native lately, no more Core Data stuggles. |
Groovy, thanks @MattFoley! |
LGTM |
To allow Vokoder to be used in app extensions, some small parts had to be removed. Specifically, the parts that call
[UIApplication sharedApplication]
andUIAlertView
/UIAlertController
. To achieve this, I added a new subspace that handles the nitty gritty of adding a new preprocessor definition that we can use. (Apple did not expose any way that I can tell to alert the compiler that it is compiling for an app extension.) Without this, Vokoder would fail to build when included in an app extension target.I added a new today extension target that will be built on Travis to verify that there are no errors. (Thus the giant diff.)
@brockboland, @vokal-isaac, @bryanluby, @designatednerd code review?