Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/script type #47

Closed
wants to merge 6 commits into from
Closed

Pr/script type #47

wants to merge 6 commits into from

Conversation

abuyoyo
Copy link
Contributor

@abuyoyo abuyoyo commented Mar 17, 2020

Fixes #46

Proposed Changes

  • Added test case: testRemoveDeprecatedTypeFromScriptTag that tests for default settings and doRemoveDeprecatedTypeFromScriptTag(false) with script string with and without src attribute. Test fails.
  • Removed isset($allAttr['src']) test when doing isDoRemoveDeprecatedTypeFromScriptTag(). Test passes.
  • Fixed base_result files used in testMinifyBase() to account for changes.

This change is Reviewable

- closes voku#46
- doRemoveDeprecatedTypeFromScriptTag now applies to script tags without src attribute
@coveralls
Copy link

coveralls commented Mar 17, 2020

Coverage Status

Coverage remained the same at 93.856% when pulling 776965d on abuyoyo:pr/script-type into d20ce12 on voku:master.

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage     93.18%   93.18%           
  Complexity      299      299           
=========================================
  Files             2        2           
  Lines           558      558           
=========================================
  Hits            520      520           
  Misses           38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20ce12...776965d. Read the comment docs.

voku added a commit that referenced this pull request Mar 22, 2020
@voku voku closed this Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants