Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PHPDefineConstant much shorter #7

Merged
merged 1 commit into from Jul 18, 2020
Merged

Conversation

szepeviktor
Copy link
Contributor

Spare some bytes on the disk.

@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #7 into master will increase coverage by 0.46%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
+ Coverage     29.28%   29.75%   +0.46%     
+ Complexity      735      733       -2     
============================================
  Files            29       29              
  Lines          1820     1815       -5     
============================================
+ Hits            533      540       +7     
+ Misses         1287     1275      -12     
Impacted Files Coverage Δ Complexity Δ
...c/voku/SimplePhpParser/Model/PHPDefineConstant.php 0.00% <0.00%> (ø) 7.00 <0.00> (-2.00)
...rc/voku/SimplePhpParser/Parsers/PhpCodeChecker.php 92.24% <0.00%> (+3.01%) 127.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e030609...7d0833a. Read the comment docs.

@voku voku merged commit d88631d into voku:master Jul 18, 2020
@szepeviktor szepeviktor deleted the patch-2 branch July 18, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants