Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many single white spaces are removed #41

Closed
Kubik-Rubik opened this issue Nov 18, 2019 · 1 comment
Closed

Too many single white spaces are removed #41

Kubik-Rubik opened this issue Nov 18, 2019 · 1 comment

Comments

@Kubik-Rubik
Copy link

Kubik-Rubik commented Nov 18, 2019

Hey @voku,

thanks for the great script!

Though, I have a small issue with the latest version. Single white spaces are removed between span elements. In my case only the first white space is preserved, all other for the next span elements are removed. The problem is that buttons are loaded via CSS and with the optimization they are glued together.

Original:

<p><span class="label-icons">XXX</span> <span class="label-icons label-free">FREE</span> <span class="label-icons label-pro">PRO</span> <span class="label-icons label-popular">POPULAR</span> <span class="label-icons label-community">COMMUNITY CHOICE</span></p>

Minified:

<p><span class="label-icons">XXX</span> <span class="label-free label-icons">FREE</span><span class="label-icons label-pro">PRO</span><span class="label-icons label-popular">POPULAR</span><span class="label-community label-icons">COMMUNITY CHOICE</span>

Option doRemoveSpacesBetweenTags() is not set.

Thanks!

voku added a commit that referenced this issue Nov 18, 2019
@voku
Copy link
Owner

voku commented Nov 18, 2019

Thanks for the bug report. Fixed in version 4.0.7.

@voku voku closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants