Simplify and update phpstan configuration

[szepeviktor]

Makes PHPStan return "OK"

---

This change is 

[coveralls]

Coverage remained the same at 80.786% when pulling fe695e0 on szepeviktor:patch-1 into 5445d44 on voku:master.

[coveralls]

Coverage remained the same at 80.786% when pulling ffd47a7 on szepeviktor:patch-1 into 5445d44 on voku:master.

[szepeviktor]

On PHP 7.3 with PHP_COMPOSER_SETUP=lowest PHP_EXTENSION=false PHPStan complains.

 ------ -------------------------------------------------------------------- 

  Line   voku/helper/UTF8.php                                                

 ------ -------------------------------------------------------------------- 

  8313   Function mb_str_split not found.                                    

 ------ -------------------------------------------------------------------- 

How could it be?

[szepeviktor]

Could it be this change?

• use "mb_str_split" with PHP >= 7.4 + mbstring support (performance++)

[voku]

@szepeviktor Thanks for the clean-up and I think phpstan did not understand the if (Bootup::is_php('7.4')) { check.

[szepeviktor]

I think if (Bootup::is_php('7.4')) { is not executed on PHP 7.3.
That is why mb_str_split() is not available.

[szepeviktor]

...I see!

If we teach is_php() to PHPStan it may cease to complain.

[szepeviktor]

@voku Please see the conversion on this matter: phpstan/phpstan#3576 (comment)

What do you think about function_exists() instead of Bootup::is_php() ?

[voku]

function_exists should work and we can also cache the result, so that we do not check this every time.

[szepeviktor]

we can also cache the result, so that we do not check this every time

1M function_exists calls take 0.064774036407471 seconds on my slow server.

<?php

$start = microtime(true);
for ($run = 0; $run < 1e6; $run += 1) {
    $exists = function_exists('mb_str_split');
}
echo microtime(true) - $start, "\n";

So 1 call takes 64 nanosec :)

[voku]

@szepeviktor I added the function_exists check but phpstan still complains about Function mb_str_split not found. (https://travis-ci.org/github/voku/portable-utf8/jobs/705962575) :-/ I think I did something wrong because I can't see it on my local system?

[szepeviktor]

I think I did something wrong because I can't see it on my local system?

No! That is fine.
The above linked PHPStan issue is a feature request.

Currently the only solution is to define the function for PHPStan only.

parameters:
    scanFiles:
        - tests/phpstan/functions.php

A stub is enough.

[szepeviktor]

I can't see it on my local system?

Maybe your PHP version is not 7.3 ...