-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated readme #5
Conversation
|
||
``` | ||
cd authboss-sample | ||
export GOPATH=`pwd` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't typical Go workflow. We don't use Godeps or Glide which would require this. As such I think the instructions should be modified to reflect that.
ok - which workflow are you using ? |
Just the plain Go one. Where there's only a single GOPATH, so setting GOPATH isn't required (unless you're also showing people how to install Go). |
I am also using |
@josephmisiti Sorry, the e-mail notification for your latest comment got lost. https://golang.org/doc/code.html Your workflow doesn't work if you're building libraries, for example if you were to pull down authboss in this same manner and then try to use it from a different project on your local machine it would break because it's outside of a GOPATH and you would have to download it again. And if you are using it as a crude form of vendoring I'd highly suggest you try godep or glide instead which use the Go 1.5 vendoring experiment to do the more correct thing. If you use a single GOPATH with go get github.com/go-authboss/authboss-sample
cd $GOPATH/src/github.com/go-authboss/authboss-sample
./authboss-sample |
cool thank you ! On Tue, Dec 8, 2015 at 11:24 AM, Aaron L notifications@github.com wrote:
|
Would you like to update this pull request to match instructions like that? It was thanks to you that this issue will be addressed after all, should have your authorship in the git log :) |
PR is stagnant. Closing. |
minor PR - added some directions on how to get started for people new to go