Layers: Speed up qemu by not bisecting #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this speed things up, we can also remove the "slow layer" warning. |
|
No response back on issue #585, so hopefully this actually fixes the problem, but I guess we need to try breaking to find out... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we previously were bisecting the address space to determine whether the data was compressed. Instead we now mask the low 12 bits, because QEMU pages are a fix size of 0x1000 bytes. This provides a significant speed-up, but testing to ensure that the results are identical to the old implementation would be useful...
Fixes #585