Skip to content

Commit

Permalink
fix some review comments
Browse files Browse the repository at this point in the history
Signed-off-by: lowang-bh <lhui_wang@163.com>
  • Loading branch information
lowang-bh committed Jul 31, 2024
1 parent 2b02a38 commit 4bc4e4b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions pkg/scheduler/actions/reclaim/reclaim.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func (ra *Action) Execute(ssn *framework.Session) {
// When filtering candidate nodes, need to consider the node statusSets instead of the err information.
// refer to kube-scheduler preemption code: https://github.com/kubernetes/kubernetes/blob/9d87fa215d9e8020abdc17132d1252536cd752d2/pkg/scheduler/framework/preemption/preemption.go#L422
if err := ssn.PredicateWhenPreempt(task, n); err != nil {
klog.V(4).Infof("Reclaim predicate for task %s/%s on node %s return error %v ", task.Namespace, task.Name, n.Name, err)
continue
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/scheduler/plugins/extender/extender.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ func (ep *extenderPlugin) OnSessionOpen(ssn *framework.Session) {
if len(resp.ErrorMessage) == 0 {
return nil
}
// keep compatibility with old behavior: error messages length is not zero
// but didn't return a code, and code will be 0 for default. Change code to zero for corresponding
// keep compatibility with old behavior: error messages length is not zero,
// but didn't return a code, and code will be 0 for default. Change code to Error for corresponding
if resp.Code == api.Success {
resp.Code = api.Error
}
Expand Down
1 change: 0 additions & 1 deletion pkg/scheduler/plugins/usage/usage.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ func (up *usagePlugin) OnSessionOpen(ssn *framework.Session) {
klog.V(4).Infof("The period(%s) is empty or the usage metrics data is not updated for more than %v minutes, "+
"Usage plugin filter for task %s/%s on node %s pass, metrics time is %v. ", up.period, MetricsActiveTime, task.Namespace, task.Name, node.Name, node.ResourceUsage.MetricsTime)

usageStatus.Code = api.Success
return nil
}

Expand Down

0 comments on commit 4bc4e4b

Please sign in to comment.