Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe a mismatch in allocate action? #1358

Closed
yzs981130 opened this issue Mar 12, 2021 · 2 comments · Fixed by #1360
Closed

Maybe a mismatch in allocate action? #1358

yzs981130 opened this issue Mar 12, 2021 · 2 comments · Fixed by #1360
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@yzs981130
Copy link
Contributor

In action allocate, there are two approaches to allocate job resources, according to allocate idle or releasing resource. Namely

if err := stmt.Allocate(task, node.Name); err != nil {

if err := ssn.Pipeline(task, node.Name); err != nil {

So is there any reason for not using stmt.Pipeline in the later occasion?

And will later ssn.Pipeline cause status mismatch when gang is not met and stmt.Discard is called, because the Pipeline operation has not been recorded in stmt?

@yzs981130 yzs981130 added the kind/bug Categorizes issue or PR as related to a bug. label Mar 12, 2021
@k82cn
Copy link
Member

k82cn commented Mar 12, 2021

I think that's a bug although no impact to the result.

@Thor-wl
Copy link
Member

Thor-wl commented Mar 12, 2021

Thanks for your reporting! @yzs981130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants