Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong Pipeline in action allocate #1360

Merged
merged 5 commits into from Apr 13, 2021
Merged

fix wrong Pipeline in action allocate #1360

merged 5 commits into from Apr 13, 2021

Conversation

yzs981130
Copy link
Contributor

fix #1358

@volcano-sh-bot
Copy link
Contributor

Welcome @yzs981130!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2021
@k82cn
Copy link
Member

k82cn commented Mar 15, 2021

/lgtm
/approve

btw, please sign DCO

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 15, 2021
@yzs981130
fix wrong Pipeline in action allocate
f84cdff 
Signed-off-by: Tizen Ye <yzs981130@126.com>
@yzs981130 yzs981130 force-pushed the yzs/action_allocate_statement_commit-patch branch from 73c3925 to f84cdff Compare March 15, 2021 05:12
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021
@yzs981130
Copy link
Contributor Author

/lgtm
/approve

btw, please sign DCO

Have fixed DCO. Sorry for the delay.

@k82cn
Copy link
Member

k82cn commented Mar 15, 2021

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021
@Thor-wl
Copy link
Member

Thor-wl commented Mar 16, 2021

/approve
/lgtm

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@zen-xu
Copy link
Contributor

zen-xu commented Apr 7, 2021

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, Thor-wl, yzs981130, zen-xu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zen-xu zen-xu removed their assignment Apr 7, 2021
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2021
@Thor-wl
Copy link
Member

Thor-wl commented Apr 13, 2021

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2021
@Thor-wl Thor-wl merged commit 3e330e1 into volcano-sh:master Apr 13, 2021
peiniliu pushed a commit to peiniliu/volcano that referenced this pull request Aug 27, 2021
@yzs981130 @k82cn
@Thor-wl @peiniliu
fix wrong Pipeline in action allocate (volcano-sh#1360)
df5ea91 
Signed-off-by: Tizen Ye <yzs981130@126.com>

Co-authored-by: Klaus Ma <klaus1982.cn@hotmail.com>
Co-authored-by: WuLei <13164644535@163.com>
Signed-off-by: peiniliu <peini.liu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcorj-mizar alcorj-mizar Awaiting requested review from alcorj-mizar

@william-wang william-wang Awaiting requested review from william-wang

Assignees

@k82cn k82cn

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe a mismatch in allocate action?
5 participants
@yzs981130 @volcano-sh-bot @k82cn @Thor-wl @zen-xu