Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add predicate with equivalence cache #1165

Merged
merged 9 commits into from
May 24, 2021

Conversation

huone1
Copy link
Contributor

@huone1 huone1 commented Nov 28, 2020

feat: add predicate with equivalence cache to approve the scheduler performance

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2020
…erformance

Signed-off-by: huone1 <huwanxing@huawei.com>
@Thor-wl
Copy link
Contributor

Thor-wl commented Dec 15, 2020

@huone1 please close and reopen this PR

@huone1 huone1 closed this Dec 16, 2020
@huone1 huone1 reopened this Dec 16, 2020
@huone1 huone1 closed this Dec 16, 2020
@huone1 huone1 reopened this Dec 16, 2020
@huone1 huone1 closed this Dec 16, 2020
@huone1 huone1 reopened this Dec 16, 2020
@huone1 huone1 closed this Dec 17, 2020
@huone1 huone1 reopened this Dec 17, 2020
@huone1 huone1 closed this Dec 22, 2020
@huone1 huone1 reopened this Dec 22, 2020
@huone1 huone1 closed this Jan 25, 2021
@huone1 huone1 reopened this Jan 25, 2021
Signed-off-by: huone1 <huwanxing@huawei.com>
@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 18, 2021

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 18, 2021
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
Signed-off-by: huone1 <huwanxing@huawei.com>
@Thor-wl
Copy link
Contributor

Thor-wl commented May 21, 2021

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@wpeng102
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2021
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huone1, Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Thor-wl
Copy link
Contributor

Thor-wl commented May 24, 2021

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2021
@Thor-wl Thor-wl merged commit e87e2f3 into volcano-sh:master May 24, 2021
@huone1 huone1 deleted the predicates_cache branch August 4, 2021 02:45
peiniliu pushed a commit to peiniliu/volcano that referenced this pull request Aug 27, 2021
 feat: add predicate with equivalence cache to approve the scheduler performance

Signed-off-by: huone1 <huwanxing@huawei.com>
@zhuqi-lucas
Copy link

Hi guys, if we have performance test for the cache enabled, how much gain we will have when the cache enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants