Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some bug about event and workqueue #254

Merged
merged 7 commits into from Jul 3, 2019
Merged

fix some bug about event and workqueue #254

merged 7 commits into from Jul 3, 2019

Conversation

lminzhw
Copy link
Contributor

@lminzhw lminzhw commented Jun 26, 2019 •
edited

  1. debug try to delete bug
  2. complete pods in job event
  3. fix admit job minA >= 0
  4. fix ut using watch

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 26, 2019
@hzxuzhonghu
Copy link
Collaborator

/assign @TommyLike

@volcano-sh-bot volcano-sh-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2019
@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2019
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @lminzhw,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7f169b40-9d60-11e9-9589-8781193ec3af

@k82cn
Copy link
Member

k82cn commented Jul 3, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, lminzhw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019
@volcano-sh-bot volcano-sh-bot merged commit 7cdd739 into volcano-sh:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@TommyLike TommyLike

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lminzhw @hzxuzhonghu @TravisBuddy @k82cn @volcano-sh-bot @TommyLike @wangyuqing4