Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang version to 1.19.5 #2666

Closed
wants to merge 1 commit into from
Closed

update golang version to 1.19.5 #2666

wants to merge 1 commit into from

Conversation

yanggangtony
Copy link

Signed-off-by: yanggang gang.yang@daocloud.io

go1.19.5 have releaed for a time. Update to follow it..
Also go1.20 is released. maybe we should wait for a several versions after ,and follow it.

go release

Signed-off-by: yanggang <gang.yang@daocloud.io>
@volcano-sh-bot
Copy link
Contributor

Welcome @yanggangtony!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hzxuzhonghu
You can assign the PR to them by writing /assign @hzxuzhonghu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2023
Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanggangtony Hey, kindly to ask if there is something making sense for Volcano in go v1.19.5?

@yanggangtony
Copy link
Author

kindly to ask if there is something making sense for Volcano in go v1.19.5?

no , just upgrade the go version to match the latest go1.19.
but now 1.20 have released.
may be update to it in a near feature?

Is there a good solve to make go: latest? for no need to update go version again?

@Thor-wl
thansk for review.

@wangyang0616
Copy link
Member

It is recommended to postpone the upgrade of the golang version.

At present, the latest version of k8s supported by Volcano is v1.25, and k8s v1.25 also uses go 1.19. If there is no special requirement, we can adapt k8s v1.27 version, Corresponding to upgrade the major version of golang.

@Thor-wl
Copy link
Contributor

Thor-wl commented Feb 8, 2023

t is recommended to postpone the upgrade of the golang version.

At present, the latest version of k8s supported by Volcano is v1.25, and k8s v1.25 also uses go 1.19. If there is no special requirement, we can adapt k8s v1.27 version, Corresponding to upgrade the major version of golang.

Acctually, I'm on @wangyang0616 's side.

@yanggangtony
Copy link
Author

@Thor-wl @wangyang0616
The intents postpone the upgrade of the golang version i have known , version 1.20 will not going to current schedule..

So this pr is keep stale? or wait a 1.19 new version have come then to follow it ? for example 1.19.6 is released ,then follow 1.19.5? like these way?

thanks yours suggestion.

@stale
Copy link

stale bot commented Apr 11, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2023
@stale stale bot closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants