fix: undefined: buildJmpDirective on arm64 machine #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
lowang-bh
force-pushed
the
fix_arm64_error
branch
from
437b2dd
to
c529151
Compare
lowang-bh
force-pushed
the
fix_arm64_error
branch
from
a70e0da
to
7df07c9
Compare
|
same error, it looks have nothing to do with this commit: |
@wangyang0616 Cloud you please check this error? |
lowang-bh
force-pushed
the
fix_arm64_error
branch
from
7df07c9
to
263aca9
Compare
|
without this commit, there are build errors on master branch when run unit-test even in docker: ➜ volcano git:(master) ✗ docker run --rm -it -v ./:/go/src/volcano.sh/ -w /go/src/volcano.sh/ golang:1.19.4 bash
root@c8a0428409b9:/go/src/volcano.sh# make unit-test
go clean -testcache
go test -p 8 -race $(find pkg cmd -type f -name '*_test.go' | sed -r 's|/[^/]+$||' | sort | uniq | sed "s|^|volcano.sh/volcano/|")
# github.com/agiledragon/gomonkey/v2
vendor/github.com/agiledragon/gomonkey/v2/patch.go:163:10: undefined: buildJmpDirective
ok volcano.sh/volcano/cmd/controller-manager/app/options 0.073s
ok volcano.sh/volcano/cmd/scheduler/app/options 0.034s
ok volcano.sh/volcano/pkg/cli/job 0.220s
ok volcano.sh/volcano/pkg/cli/queue 0.176s
ok volcano.sh/volcano/pkg/cli/util 0.265s
ok volcano.sh/volcano/pkg/cli/vcancel 0.098s
ok volcano.sh/volcano/pkg/cli/vresume 0.190s
ok volcano.sh/volcano/pkg/cli/vsuspend 0.177s
ok volcano.sh/volcano/pkg/controllers/apis 0.049s
ok volcano.sh/volcano/pkg/controllers/cache 0.044s
ok volcano.sh/volcano/pkg/controllers/garbagecollector 0.138s
FAIL volcano.sh/volcano/pkg/controllers/job [build failed]
ok volcano.sh/volcano/pkg/controllers/job/helpers 0.132s
ok volcano.sh/volcano/pkg/controllers/job/plugins/distributed-framework/mpi 0.103s
ok volcano.sh/volcano/pkg/controllers/job/plugins/distributed-framework/pytorch 0.135s
ok volcano.sh/volcano/pkg/controllers/job/plugins/distributed-framework/tensorflow 0.128s
ok volcano.sh/volcano/pkg/controllers/job/plugins/ssh 0.142s
ok volcano.sh/volcano/pkg/controllers/podgroup 0.200s
ok volcano.sh/volcano/pkg/controllers/queue 0.193s
ok volcano.sh/volcano/pkg/controllers/util 0.210s
ok volcano.sh/volcano/pkg/scheduler 0.226s
FAIL volcano.sh/volcano/pkg/scheduler/actions/allocate [build failed]
ok volcano.sh/volcano/pkg/scheduler/actions/preempt 0.147s
ok volcano.sh/volcano/pkg/scheduler/actions/reclaim 0.158s
ok volcano.sh/volcano/pkg/scheduler/actions/shuffle 0.097s
ok volcano.sh/volcano/pkg/scheduler/api 0.160s
ok volcano.sh/volcano/pkg/scheduler/api/devices/nvidia/gpushare 0.173s
ok volcano.sh/volcano/pkg/scheduler/api/helpers 0.217s
ok volcano.sh/volcano/pkg/scheduler/cache 0.159s
ok volcano.sh/volcano/pkg/scheduler/capabilities/volumebinding 29.356s
ok volcano.sh/volcano/pkg/scheduler/framework 0.284s
ok volcano.sh/volcano/pkg/scheduler/metrics/source 0.052s
ok volcano.sh/volcano/pkg/scheduler/plugins/binpack 0.117s
ok volcano.sh/volcano/pkg/scheduler/plugins/cdp 0.185s
FAIL volcano.sh/volcano/pkg/scheduler/plugins/drf [build failed]
ok volcano.sh/volcano/pkg/scheduler/plugins/numaaware/policy 0.184s
ok volcano.sh/volcano/pkg/scheduler/plugins/numaaware/provider/cpumanager 0.135s
FAIL volcano.sh/volcano/pkg/scheduler/plugins/predicates [build failed]
FAIL volcano.sh/volcano/pkg/scheduler/plugins/proportion [build failed]
ok volcano.sh/volcano/pkg/scheduler/plugins/task-topology 0.135s
ok volcano.sh/volcano/pkg/scheduler/plugins/tdm 0.187s
ok volcano.sh/volcano/pkg/scheduler/util 0.150s
ok volcano.sh/volcano/pkg/webhooks/admission/jobs/mutate 0.225s
ok volcano.sh/volcano/pkg/webhooks/admission/jobs/plugins/mpi 0.121s
ok volcano.sh/volcano/pkg/webhooks/admission/jobs/validate 0.100s
ok volcano.sh/volcano/pkg/webhooks/admission/pods/mutate 0.188s
ok volcano.sh/volcano/pkg/webhooks/admission/pods/validate 0.095s
ok volcano.sh/volcano/pkg/webhooks/admission/queues/mutate 0.071s
ok volcano.sh/volcano/pkg/webhooks/admission/queues/validate 0.069s
FAIL
make: *** [Makefile:104: unit-test] Error 2
root@c8a0428409b9:/go/src/volcano.sh#With this fix: |
|
@Yikun Please help to review this pr, thanks. |
|
/approve |
|
/lgtm |
lowang-bh
force-pushed
the
fix_arm64_error
branch
from
263aca9
to
c02e652
Compare
This was referenced May 19, 2023
I don't have permission to merge, currently there is only one person with permission to merge in Volcano, he is @william-wang |
|
/priority important-soon |
|
/assign @william-wang |
|
lowang-bh
force-pushed
the
fix_arm64_error
branch
from
c02e652
to
dfed7f1
Compare
Signed-off-by: lowang_bh <lhui_wang@163.com>
lowang-bh
force-pushed
the
fix_arm64_error
branch
from
dfed7f1
to
348cc21
Compare
volcano-sh-bot
added
size/XS
|
@william-wang would you please merge this with high priority, please? Developing on mac depend on it. |
|
please make CI happy |
|
trigger CI |
|
I think this CI is broken. |
|
trigger ci |
|
@william-wang Can this fix be merge now? It has been hung up for a few months till now. |
Thor-wl
approved these changes
Jul 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef, Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildJmpDirectivenot define on arm64 machine, eg, macbook m1/m2update gomonkey to v2.2.0 or higher.
fix #2804