Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nodeinfo clone #2827

Merged
merged 1 commit into from May 24, 2023
Merged

fix: nodeinfo clone #2827

merged 1 commit into from May 24, 2023

Conversation

lowang-bh
Copy link
Member

fix #2826

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2023
@wangyang0616
Copy link
Member

It's ok to me.
Please help to review. Thanks! @jiangkaihua @william-wang

@wangyang0616
Copy link
Member

/priority important-soon

@volcano-sh-bot volcano-sh-bot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 16, 2023
@lowang-bh
fix: node infor clone
05cd599 
Signed-off-by: lowang_bh <lhui_wang@163.com>
jiangkaihua
jiangkaihua reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@jiangkaihua jiangkaihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
william-wang
william-wang approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@william-wang william-wang changed the title fix: node infor clone fix: nodeinfo clone May 23, 2023
@volcano-sh-bot volcano-sh-bot merged commit 53f93c8 into volcano-sh:master May 24, 2023
13 checks passed
@lowang-bh lowang-bh mentioned this pull request May 24, 2023
Merged
@lowang-bh lowang-bh deleted the fixNodeClone branch May 27, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangkaihua jiangkaihua jiangkaihua left review comments

@william-wang william-wang william-wang approved these changes

@hudson741 hudson741 Awaiting requested review from hudson741

Assignees

@william-wang william-wang

@jiangkaihua jiangkaihua

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The volcano scheduler panic in the predicate phase
5 participants
@lowang-bh @wangyang0616 @volcano-sh-bot @william-wang @jiangkaihua