fix PodToplogySpread plugin violates maxSkew #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
| node.AddPod(pod) | ||
| klog.V(4).Infof("node order, update pod %s/%s allocate to node [%s]", pod.Namespace, pod.Name, nodeName) | ||
| } | ||
| }, | ||
| DeallocateFunc: func(event *framework.Event) { |
There was a problem hiding this comment.
@Monokaix Don't we need to remove the DeallocateFunc?
There was a problem hiding this comment.
yeah it should be removed too.
volcano-sh-bot
added
size/M
|
@Monokaix please take a look at the e2e failure case |
Signed-off-by: Xuzheng Chang <changxuzheng@huawei.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr #2606 refact nodeorder and predict plugin and move
util.NewPodListerFromNode(ssn)from plugin local to global variable, so we just need add pod into cache once at eventHandler.fix #2928