Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic issue with job taskMinAvailable clone #3008

Merged
merged 1 commit into from Aug 1, 2023
Merged

Fix panic issue with job taskMinAvailable clone #3008

merged 1 commit into from Aug 1, 2023

Conversation

Tongruizhe
Copy link
Contributor

Fix #3007

@volcano-sh-bot
Copy link
Contributor

Welcome @Tongruizhe!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2023
@Tongruizhe
Copy link
Contributor Author

/assign @qiankunli

@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 1, 2023
Thor-wl
Thor-wl reviewed Aug 1, 2023
View reviewed changes
pkg/scheduler/api/job_info.go Outdated
@@ -574,7 +574,7 @@ func (ji *JobInfo) Clone() *JobInfo {
PodGroup: ji.PodGroup.Clone(),

TaskStatusIndex: map[TaskStatus]tasksMap{},
TaskMinAvailable: ji.TaskMinAvailable,
TaskMinAvailable: map[TaskID]int32{},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your report and bug fix. It's OK for me. A small tip is that making use of make(map[TaskID]int32{}) instead of map directly maybe better. Anyway, it's not something matters.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to make...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more graceful change is making map with cap ^_^.

@Tongruizhe
Fix panic issue with job taskMinAvailable clone
bf0a7a6 
Signed-off-by: Tongruizhe <tongruizhe@163.com>
@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@volcano-sh-bot volcano-sh-bot merged commit 05c9d71 into volcano-sh:master Aug 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh left review comments

@rt849122 rt849122 rt849122 left review comments

@Thor-wl Thor-wl Thor-wl approved these changes

@william-wang william-wang Awaiting requested review from william-wang

Assignees

@qiankunli qiankunli

@lowang-bh lowang-bh

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic because concurrent access of JobInfo.TaskMinAvailable
6 participants
@Tongruizhe @volcano-sh-bot @lowang-bh @Thor-wl @rt849122 @qiankunli