-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove inqueue job phase #421
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, wangyuqing4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @wangyuqing4, TravisCI finished with status TravisBuddy Request Identifier: 0a425690-c251-11e9-86a4-77838e0d0b7a |
Hey @wangyuqing4, TravisCI finished with status TravisBuddy Request Identifier: adf918f0-c256-11e9-86a4-77838e0d0b7a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, except a nit
@@ -210,6 +186,10 @@ func (cc *Controller) syncJob(jobInfo *apis.JobInfo, updateStatus state.UpdateSt | |||
return nil | |||
} | |||
|
|||
if err := cc.createJob(job); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confusing createJob in synJob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better rename it
Hey @wangyuqing4, TravisCI finished with status TravisBuddy Request Identifier: 2beef6f0-c264-11e9-86a4-77838e0d0b7a |
346acc0
to
51b6fd4
Compare
Hey @wangyuqing4, TravisCI finished with status TravisBuddy Request Identifier: abdc8400-c326-11e9-a73e-8f33893bc238 |
Hey @wangyuqing4, TravisCI finished with status TravisBuddy Request Identifier: 67fd5cb0-c348-11e9-a73e-8f33893bc238 |
51b6fd4
to
9fc4c04
Compare
/lgtm |
pr #370 add ValidatingWebhookConfiguration volcano-validate-pod, limit CREATE pods.
so inqueue job phase can be removed.