Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admission e2e test #45

Merged
merged 4 commits into from Mar 26, 2019
Merged

Add admission e2e test #45

merged 4 commits into from Mar 26, 2019

Conversation

TommyLike
Copy link
Contributor

@TommyLike TommyLike commented Mar 25, 2019 •
edited

  • Add e2e testcases for admission service
  • Remove job version from mutating webhook, since it's not working for subresource, Now job version is started from 0.
  • Now e2e test support not clean up the kubernetes cluster with command: CLEANUP_CLUSTER=-1 make e2e-test-kind
  • Add conformance and nodeorder plugins in kube batch
  • Fix Resource Sub issue in kube batch reclaim & preempt Actions
  • Increase timeout when deleting namespace and queue
  • Add lock in TaskComplete function

for #31

k82cn
k82cn reviewed Mar 25, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@TommyLike TommyLike force-pushed the feature/support-admission-test branch from 78bd4a1 to 4ef07b8 Compare March 25, 2019 08:53
@TommyLike
Copy link
Contributor Author

There is a issue when tested locally: kubernetes-retired/kube-batch#659

@TommyLike TommyLike force-pushed the feature/support-admission-test branch from 4ef07b8 to d9d8b71 Compare March 25, 2019 10:47
@TommyLike TommyLike force-pushed the feature/support-admission-test branch 4 times, most recently from 1cb6222 to 2fd8921 Compare March 26, 2019 01:46
@TommyLike TommyLike force-pushed the feature/support-admission-test branch from 2fd8921 to 03134d0 Compare March 26, 2019 02:20
@TommyLike
Copy link
Contributor Author

Please review it again

@k82cn k82cn merged commit a045f24 into master Mar 26, 2019
@k82cn k82cn deleted the feature/support-admission-test branch March 26, 2019 06:00
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Apr 30, 2019
Merge pull request volcano-sh#45 from volcano-sh/feature/support-admi…
e329e7c 
…ssion-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TommyLike @k82cn