Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to k8s 1.18.3 #855

Merged
merged 8 commits into from
Jun 11, 2020
Merged

Bump to k8s 1.18.3 #855

merged 8 commits into from
Jun 11, 2020

Conversation

hzxuzhonghu
Copy link
Collaborator

No description provided.

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 10, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7f837380-aac2-11ea-9064-4d6590cbb359

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: abec5130-aac2-11ea-9064-4d6590cbb359

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 00656300-aad2-11ea-9064-4d6590cbb359

k82cn
k82cn reviewed Jun 10, 2020
View reviewed changes
pkg/scheduler/framework/framework.go
@@ -139,7 +138,7 @@ func (f *framework) VolumeBinder() scheduling.SchedulerVolumeBinder {
}

func NewFrameworkHandle(pods []*v1.Pod, nodes []*v1.Node) v1alpha1.FrameworkHandle {
snapshot := k8scache.NewSnapshot(pods, nodes)
snapshot := cache.NewSnapshot(pods, nodes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's open an issue in upstream to make cache public.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes/kubernetes#91983

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's move this PR forward; I don-t think we will have a conclusion in a shot time :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's move this PR forward; I don-t think we will have a conclusion in a shot time :(

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e28cbbf0-aae8-11ea-b056-2f6ef3b381c7

@hzxuzhonghu
Copy link
Collaborator Author

@k82cn please take a look at the scheduling part, especially the nodeorders.go and predicate.go

@k82cn
Copy link
Member

k82cn commented Jun 11, 2020

@k82cn please take a look at the scheduling part, especially the nodeorders.go and predicate.go

How can I find them in 1.4k files and 15 commits? please separate this PR to some meaningful commits, e.g. scheduler, controller, vendor, test ...

@k82cn
Copy link
Member

k82cn commented Jun 11, 2020

/approve
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@volcano-sh-bot volcano-sh-bot merged commit 212a105 into volcano-sh:master Jun 11, 2020
@hzxuzhonghu hzxuzhonghu deleted the k8s-dep branch June 11, 2020 12:06
@hzxuzhonghu hzxuzhonghu mentioned this pull request Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hzxuzhonghu @TravisBuddy @k82cn @volcano-sh-bot