Skip to content

Commit

Permalink
Remove requiresValue method as we don't need it for now.
Browse files Browse the repository at this point in the history
  • Loading branch information
ijuma committed Oct 15, 2009
1 parent 39f633b commit 5daf42c
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 33 deletions.
Expand Up @@ -28,10 +28,6 @@
*/
public class ArbitraryInconsistencyResolver<T> implements InconsistencyResolver<T> {

public boolean requiresValue() {
return false;
}

/**
* Arbitrarily resolve the inconsistency by choosing the first object if
* there is one.
Expand Down
8 changes: 0 additions & 8 deletions src/java/voldemort/versioning/ChainedResolver.java
Expand Up @@ -38,14 +38,6 @@ public ChainedResolver(InconsistencyResolver<T>... resolvers) {
this.resolvers.add(Utils.notNull(resolver));
}

public boolean requiresValue() {
for(InconsistencyResolver<T> resolver: resolvers) {
if(resolver.requiresValue())
return true;
}
return false;
}

public List<T> resolveConflicts(List<T> items) {
for(InconsistencyResolver<T> resolver: resolvers) {
if(items.size() <= 1)
Expand Down
Expand Up @@ -32,9 +32,4 @@ public List<T> resolveConflicts(List<T> items) {
else
return items;
}

public boolean requiresValue() {
return false;
}

}
2 changes: 0 additions & 2 deletions src/java/voldemort/versioning/InconsistencyResolver.java
Expand Up @@ -28,8 +28,6 @@
*/
public interface InconsistencyResolver<T> {

public boolean requiresValue();

/**
* Take two different versions of an object and combine them into a single
* version of the object Implementations must maintain the contract that
Expand Down
Expand Up @@ -50,9 +50,4 @@ public List<Versioned<T>> resolveConflicts(List<Versioned<T>> items) {
return Collections.singletonList(new Versioned<T>(merged, clock));
}
}

public boolean requiresValue() {
return true;
}

}
Expand Up @@ -44,8 +44,4 @@ public List<Versioned<T>> resolveConflicts(List<Versioned<T>> items) {
return Collections.singletonList(max);
}
}

public boolean requiresValue() {
return false;
}
}
Expand Up @@ -55,9 +55,4 @@ public List<Versioned<T>> resolveConflicts(List<Versioned<T>> items) {
}
return newItems;
}

public boolean requiresValue() {
return false;
}

}

0 comments on commit 5daf42c

Please sign in to comment.