AdminClient does not obey the Client Timeout #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| adminClient = new AdminClient(clusterUrl, | ||
| new AdminClientConfig(), | ||
| new ClientConfig()); | ||
| adminClient = new AdminClient(clusterUrl); |
There was a problem hiding this comment.
This one needs a higher timeout as well, like you did in VoldemortBuildAndPushJob, right?
There was a problem hiding this comment.
I searched for the callers of the RollBackJob and there is no reference to it. There is not even a main method which is weird. Will look more into it.
1) For BuildAndPush If the Voldemort Cluster is far away from the Hadoop Cluster, the connection timeout causes the Job to fail. Increased the connection timeout in Azkaban.* files for this issue. 2) ClientConfig timeout is ignored by the AdminClient bootstrap methods and it constructs an arbitary ClientConfig. Fixed that. 3) AdminClient passes in empty AdminClientConfig and ClientConfig at multiple places. Removed that.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review the changes in AdminClient and Azkaban* files. Others can be ignored.
For BuildAndPush If the Voldemort Cluster is far away from the
Hadoop Cluster, the connection timeout causes the Job to fail.
Increased the connection timeout in Azkaban.* files for this issue.
ClientConfig timeout is ignored by the AdminClient bootstrap
methods and it constructs an arbitary ClientConfig. Fixed that.
AdminClient passes in empty AdminClientConfig and ClientConfig
at multiple places. Removed that.