-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
one-extract: broken output at 4k boundary from encrypted ONE file #7
Comments
Oops, forgot the samples, sorry… |
Hey! Thanks a lot for your report. I looked into this with @rootbsd. We're not sure whether this is an issue in msoff-crypto-tool, or whether the algorithm used by OneNote is slightly different, but the crux of the issue seems to lie in the It seems as though modifying the I'm going to raise an issue with the msoffcrypto-tool repo to see if this is something affecting any other tools using their library and/or if they have any other recommendations on what's going on here. Cheers, |
Reading the msoffcrypto-tool it looks like the author of the tool agrees with our modification that we've currently got in the repo to deal with this issue. If msoffcrypto-tool is updated in the future with a version that includes the same decrypt() function I'll revert back to using the one that ships with msoffcrypto-tool. Once again, thanks for raising this. |
First, thank you so much for providing this really cool tool!
Whilst it works perfectly for unencrypted files, I noticed that the output of encrypted contents seems to be broken at 4k boundaries. To reproduce, consider the attached two examples, containing exactly the same contents. The encrypted version requires the password
GeHeIm
:The output files,
./Test-encrypted.one_0.extracted
and./Test.one_0.extracted
are PNG images, of which the latter is usable, but the former is broken:I use the tool on Debian Bookworm, running python3 v. 3.11.2 and the standard
python3-msoffcrypto-tool
package (v. 5.0.0-1). Any idea how this issue could be fixed?TIA, Albrecht.
The text was updated successfully, but these errors were encountered: