Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T017: Do not run NGL GUI (messes with HTML rendering) #157

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented Oct 26, 2021

Description

Short

Quick fix for: #141

Long

T017 is currently rendered like this on our website:
image

Responsible for this seems to be the NGL GUI as nicely outlined here: nglviewer/nglview#988

Quick fix: Do not run NGL GUI (comment code), add comment rationalizing why, and show a screenshot of the GUI instead.

Todos

  • Add a screenshot of NGL GUI
  • Comment code to generate NGL GUI
  • Add text explaining why we do this (link to issue) and how users can load the GUI in case they run the notebook themselves
  • Rerun full notebook (always a hassle because needs to be done manually due to the NGL image rendering steps)
  • Check if the website is rendered without issues

Questions

None.

Status

  • Ready to go

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dominiquesydow dominiquesydow linked an issue Oct 26, 2021 that may be closed by this pull request
@dominiquesydow dominiquesydow merged commit c3a6308 into master Oct 26, 2021
@dominiquesydow dominiquesydow deleted the ds-t017-rm-ngl-gui branch October 26, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T017: Website rendering is incorrect
1 participant