Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Exclude T019 again from Windows CI #362

Merged
merged 9 commits into from
May 23, 2023

Conversation

dominiquesydow
Copy link
Collaborator

@dominiquesydow dominiquesydow commented May 22, 2023

Description

Remove T019 from our Windows CI as T019 cannot be run under Windows (and never has), see: #313

Todos

  • Update ci.yml so that CI for Windows skips T019
  • Add dev branch to the CI triggers for PRs, so that this PR will run the CI :)

Status

  • Ready to go

@dominiquesydow dominiquesydow self-assigned this May 22, 2023
@dominiquesydow dominiquesydow changed the title CI: Exclude T019 from Windows CI CI: Exclude T019 again from Windows CI May 22, 2023
@dominiquesydow
Copy link
Collaborator Author

@mbackenkoehler, the CI passes now for T019 under Windows as the talktorial is excluded now (fails for T001 now but I think this is just connection errors right now). Ready to merge from my side, let me know what think.

@mbackenkoehler
Copy link
Collaborator

There also is a failure in T018 now on some output check.

…fix-broken-ci

T020: update deprecated code fix broken ci
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mbackenkoehler mbackenkoehler merged commit 2cb64f9 into dev May 23, 2023
2 of 6 checks passed
@mbackenkoehler mbackenkoehler deleted the t019-exclude-windows-from-ci branch May 23, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants