Better error messages than "can't find file"

[fschutt]

I'm trying to build a project, but all I'm getting as an error is "The system can't find the file (os error 2)". It would be really helpful to know what file exactly it can't find or where the error came from.

[volks73]

Yes, that is way too generic, and I can see how that is very frustrating. I will investigate and implement a better error message.

Were you able to eventually build your project and/or discover which file was missing? Did you try to use the sub-command with a higher verbosity, i.e. > cargo wix -vvv and if so, what was the output like?

[volks73]

Fixed as of 075b6cc

[fschutt]

@volks73 You should maybe add that you have to add the %WIX%\bin directory to the %PATH.

So I had to add: C:\Program Files (x86)\WiX Toolset v3.11\bin to the PATH environment variable. You don't actually need the VS developer console to run Wix, I ran it from the git bash and it ran fine.

[fschutt]

Or do this automatically (checking if %WIX% exists and adding it to the %PATH% if it isn't already present there).

[volks73]

@volks73 You should maybe add that you have to add the %WIX%\bin directory to the %PATH.

This is mentioned in the Installation section of the README:

Note, the WiX Toolset bin folder must be added to the PATH system environment variable for the cargo wix subcommand to work properly. The default location for the WiX Toolset bin folder is: C:\Program Files (x86)\WiX Toolset\bin or C:\Program Files (x86)\Wix Toolset v3.11\bin. Please add this path to the PATH system environment variable before using this cargo subcommand.

But I have changed the wording and structure to (hopefully) be more clear.

You don't actually need the VS developer console to run Wix, I ran it from the git bash and it ran fine.

I have added information under the Usage section to the README about being able to use git bash along with any other console/prompt/terminal. I have also changed the structure to be more clear that the VS developer console is not required but recommended. Using the VS developer console is recommended because it will add the signtool application to the PATH automatically if signing the installer.

[volks73]

Or do this automatically (checking if %WIX% exists and adding it to the %PATH% if it isn't already present there).

I would hesitate to have this sub-command manipulate system environment variables. Adding a path to the PATH system environment variable should be left to an installer or admin user.

However, this sub-command does use the WIX_PATH environment variable. If the -B,--bin-path option is not used, this sub-command will look for the WIX_PATH environment variable to find the compiler (candle.exe) and linker (light.exe). If the WIX_PATH environment variable is not found, this sub-command falls back to use the PATH system environment variable, and if that fails, a better error message is now displayed indicating these various options for pointing this sub-command to the WiX binaries are available.

I did notice documentation on the WIX_PATH environment variable is missing from the sub-commands CLI help (--help), so I created a separate issue (#51) to track adding documentation about the WIX_PATH environment variable to the help.