Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cargo authors #166

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Add test cargo authors #166

merged 3 commits into from
Jul 7, 2022

Conversation

serpilliere
Copy link
Contributor

This PR is split in three commits:

  • adds authors to the generated cargo test files
  • update the ci to use stable toolchain
  • fix clippy for the stable toolchain

The ci with this pr has been tested here:
https://github.com/serpilliere/cargo-wix/actions/runs/2630611621
This PR has been created due to #165

@serpilliere serpilliere mentioned this pull request Jul 7, 2022
Merged
@volks73 volks73 self-requested a review July 7, 2022 16:26
volks73
volks73 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Owner

@volks73 volks73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding the authors to the manifest.

@volks73 volks73 merged commit f29d257 into volks73:main Jul 7, 2022
@serpilliere serpilliere deleted the add_test_cargo_authors branch July 7, 2022 16:54
@serpilliere
Copy link
Contributor Author

Thank you for the merge @volks73 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volks73 volks73 volks73 approved these changes

Assignees

@serpilliere serpilliere

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@serpilliere @volks73