Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add render_to_string to wxs::Execution #212

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Sep 1, 2023

This lets print be used more easily when using cargo-wix as a library.

@Gankra
Copy link
Contributor Author

Gankra commented Sep 1, 2023

context: I want cargo-dist to be able to check if main.wxs needs to be regenerated and report an error if you haven't opted out of it (axodotdev/cargo-dist#391), and so I need to print wxs, but I'm using cargo-wix as a library, so I don't want to write to my own stdout/file.

This lets print be used more easily when using cargo-wix as a library.
@Gankra
Copy link
Contributor Author

Gankra commented Sep 1, 2023

successfully being used in axodotdev/cargo-dist#392 🎊

@Gankra
Copy link
Contributor Author

Gankra commented Sep 1, 2023

I believe this is the last thing I need for the cargo-dist mvp integration (everything else is future improvements I can live without to start). would you be willing to publish a new release once this lands?

Copy link
Owner

@volks73 volks73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@volks73 volks73 merged commit 99cd5c2 into volks73:main Sep 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants