Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example server should not use %.1f #58

Closed
jmberg opened this issue Dec 14, 2018 · 4 comments
Closed

example server should not use %.1f #58

jmberg opened this issue Dec 14, 2018 · 4 comments

Comments

@jmberg
Copy link

jmberg commented Dec 14, 2018

The example server is printing all values with %.1f which loses precision if the scaler is less than -1, it should use %.*f instead. I've implemented that here:

jmberg@31efb5f ("sml_server: print values with the correct precision")

@andig
Copy link

andig commented Dec 14, 2018

Please open a pr

@jmberg
Copy link
Author

jmberg commented Dec 14, 2018

You have a copyright assignment form which I have no intention of signing...

@andig
Copy link

andig commented Dec 14, 2018

No problem. Obviously just taking your code won't fix that. Too bad we can't get contributions back in this case. If you want to contribute we'd be happy to welcome you on the developers mailing list to discuss the (inherited) copyright issue.

@andig andig closed this as completed Dec 14, 2018
@jmberg
Copy link
Author

jmberg commented Dec 14, 2018

If you don't actually want the copyright assignment .. I'll make a PR if/when you decide to remove it. FWIW, I've already removed it from my own repository, I'm not even pretending I'd assign any copyright to dailab for things I wrote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants