Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer install installs 23meg of jpgraph docs that no user needs #227

Closed
r00t- opened this issue Jan 20, 2015 · 13 comments
Closed

composer install installs 23meg of jpgraph docs that no user needs #227

r00t- opened this issue Jan 20, 2015 · 13 comments

Comments

@r00t-
Copy link
Contributor

r00t- commented Jan 20, 2015

root@raspberrypi:~# du -sch /srv/volkszaehler.org/vendor/jpgraph/jpgraph/lib/JpGraph/docs
23M /srv/volkszaehler.org/vendor/jpgraph/jpgraph/lib/JpGraph/docs

that (plus probably the copies in .git) accounts for at last a third of the vz.org installation footprint...
does this really have to be installed from git, given that it's used so rarely?

@jahir
Copy link
Member

jahir commented Jan 20, 2015

Surely not. How can we prevent composer from installing it?

@andig
Copy link
Contributor

andig commented Jan 21, 2015

Ups, I see. I'll create a fork and remove the docs.

Am 21.01.2015 um 00:23 schrieb jahir notifications@github.com:

Surely not. How can we prevent composer from installing it?


Reply to this email directly or view it on GitHub.

@andig
Copy link
Contributor

andig commented Jan 21, 2015

Opened issue with owner: ztec/JpGraph#7

Meanwhile forged and updated jpgraph: https://github.com/volkszaehler/JpGraph/commits/master

Updated dependencies: #229

@r00t-
Copy link
Contributor Author

r00t- commented Jan 21, 2015

let me try to clarify:

  • this is for a very rarely used feature, that most users don't know of and will never use
    (rendering graphs in the middleware instead of frontend)
  • imho this neither justifies downloding many megabytes, nor a managing a fork
  • does deleting files from git really reduce the download volume?
    matter of fact, it does not:
$ git clone https://github.com/ztec/JpGraph JpGraph_ztec
Receiving objects: 100% (2522/2522), 12.77 MiB | 2.94 MiB/s, done.
$ git clone https://github.com/volkszaehler/JpGraph JpGraph_vz
Receiving objects: 100% (2528/2528), 12.77 MiB | 4.47 MiB/s, done.  <---
18M JpGraph_vz
46M JpGraph_ztec
14M JpGraph_vz/.git
14M JpGraph_ztec/.git

isn't there a composer target that just downloads a release tarball?
and even that could be made optional

also: from what i can tell, that ztec version isn't even the official one...?
what makes it better, why do we use it over the one from jpgraph.net?
(other than that composer prefers pulling stuff from VCSes?)

@andig
Copy link
Contributor

andig commented Jan 21, 2015

isn't there a composer target that just downloads a release tarball?

Nicht bekannt- und davon werden die Daten auch nicht weniger.

also: from what i can tell, that ztec version isn't even the official one...?

es gibt kein aktuelles Composer Package da das Projekt tot ist.

what makes it better, why do we use it over the one from jpgraph.net?

Weil es funktioniert.

Anders gesagt: Du kannst aus unserem JP Repo gerne alles rausschmeissen was Dich stört, ich weiss aber nicht was davon gebraucht wird...

@andig andig closed this as completed Jan 21, 2015
@andig andig reopened this Jan 21, 2015
@andig
Copy link
Contributor

andig commented Jan 22, 2015

18M JpGraph_vz

Argh, natürlich- die Historie bleibt ja drin. Versuchs bitte nochmal, hab das Repo neu initialisiert.

@andig
Copy link
Contributor

andig commented Jan 24, 2015

Wir könnten auch auf phantomjs umstellen. Das muss unter Windows aber von Hand installiert werden?

@jahir
Copy link
Member

jahir commented Jan 25, 2015

Äh, phantomjs ist doch ein kompletter Browser, nur headless. Größenmäßig werden wir dadurch wohl eher nichts gewinnen...

@andig
Copy link
Contributor

andig commented Jan 25, 2015

Für Windows 8MB, aber stimmt. Dafür gibts dann die gleichen schicken Charts wie im Frontend.

@andig
Copy link
Contributor

andig commented Feb 19, 2015

ping

wir könnens auch einfach sein lassen, aber wenn ich mir die Mühe schon mache wäre Feedback wirklich das Mindeste :/

@mbehr1
Copy link

mbehr1 commented Feb 19, 2015

+1

@r00t-
Copy link
Contributor Author

r00t- commented Feb 19, 2015

i just noticed the problem and thought i'd report it.
i'm fine with any fix really.
so just merge #234 if you like

if you want my personal preference, then i'd make installing jpgraph optional and off by default. the feature is rarely used anyway.

@andig
Copy link
Contributor

andig commented Feb 20, 2015

Closing as wfm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants