Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Highstock to display graph #238

Closed
Xento opened this issue Feb 1, 2015 · 11 comments
Closed

Use Highstock to display graph #238

Xento opened this issue Feb 1, 2015 · 11 comments
Labels

Comments

@Xento
Copy link

Xento commented Feb 1, 2015

Is it possible, that you could switch to Highstock for displaying the graph?
http://www.highcharts.com/stock/demo
It supports touch devices, zooming, range selection and much more.

@adlerweb
Copy link
Contributor

adlerweb commented Feb 1, 2015

Commercial software - don't this this would be a good choice…

@Xento
Copy link
Author

Xento commented Feb 2, 2015

It is free for non commercial projects.

Am 01.02.2015 um 22:45 schrieb Florian Knodt notifications@github.com:

Commercial software - don't this this would be a good choice…


Reply to this email directly or view it on GitHub.

@adlerweb
Copy link
Contributor

adlerweb commented Feb 2, 2015

Volkszähler is not solely used in non-commercial environments so implementing it as a default could lead to involuntary license violations. Also the GPLv3 used here doesn't tolerate an NC-part so I don't think it would even be possible to create a bundle containing both codes.

@jahir
Copy link
Member

jahir commented Feb 2, 2015

One could code a new frontend with Highstock, but (as @adlerweb wrote) they would not probably not be allowed to re-use the current frontend code for it. Maybe there are ways to work around that (e.g. just have the API calls in the frontend code and let the user download Highstock separately), but I don't know if that's ok. Anyway, good luck with finding someone for the coding :)

@andig
Copy link
Contributor

andig commented Feb 2, 2015

It supports touch devices, zooming, range selection and much more.

@Xento: Apart from the licensing issues: what exactly are you missing with flot? As far as I understand we have touch support, zooming, we have range selection and we certainly have "much more".

Instead of describing the solution please start by explaining the feature you're missing.

PS.: Switching to highcharts would likely be 5~10 days effort exercise. If anybody wants this outside of the Volkszaehler core right now feel free to contact me.

@andig
Copy link
Contributor

andig commented Feb 2, 2015

Volkszähler is not solely used in non-commercial environments so implementing it as a default could lead to involuntary license violations.

By the respective users. Would be their responsibility if we wanted to play it that way.

Also the GPLv3 used here doesn't tolerate an NC-part so I don't think it would even be possible to create a bundle containing both codes.

What is NC? Indeed, the CC license of HighCharts (http://creativecommons.org/licenses/by-nc/3.0/) doesn't seem to be compatible with GPLv3 (https://wiki.creativecommons.org/Frequently_Asked_Questions).

@Xento
Copy link
Author

Xento commented Feb 2, 2015

Ok, here is what i'm missing.
Mostly i use Volkszähler on my iphone. So i want to Zoom in and out with two Fingers and scroll through the Timeline with one Finger.

Am 02.02.2015 um 10:43 schrieb andig notifications@github.com:

Volkszähler is not solely used in non-commercial environments so implementing it as a default could lead to involuntary license violations.

By the respective users. Would be their responsibility if we wanted to play it that way.

Also the GPLv3 used here doesn't tolerate an NC-part so I don't think it would even be possible to create a bundle containing both codes.

What is NC? Indeed, the CC license of HighCharts (http://creativecommons.org/licenses/by-nc/3.0/) doesn't seem to be compatible with GPLv3 (https://wiki.creativecommons.org/Frequently_Asked_Questions).


Reply to this email directly or view it on GitHub.

@andig
Copy link
Contributor

andig commented Feb 2, 2015

So i want to Zoom in and out with two Fingers

There is a pinch plugin for flot, I'll need to take a look.

and scroll through the Timeline with one Finger.

Pan is supported as well.

See http://justindarc.github.io/flot.touch/

@Xento
Copy link
Author

Xento commented Feb 2, 2015

I added the touch plugin for flot, but it is very ugly.
It seems that you can only zoom the graph like an image. When you zoom with highstock it generates a new graph with the selected timespan.

@andig
Copy link
Contributor

andig commented Feb 3, 2015

I added the touch plugin for flot, but it is very ugly.

So? The plugin is 4 years old and needs a little work. That is what open source is about- build on what's there and start improving it.

@andig
Copy link
Contributor

andig commented Feb 10, 2015

I've pushed an update to the plugins site. It now has what we need. All that's missing is the frontend integration to dynamically load the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants