Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Criteria for repo contributions #246

Closed
andig opened this issue Feb 20, 2015 · 9 comments
Closed

RFC: Criteria for repo contributions #246

andig opened this issue Feb 20, 2015 · 9 comments

Comments

@andig
Copy link
Contributor

andig commented Feb 20, 2015

To keep the repo in a current state I'd suggest the following ruleset for contributions:

  • core repo (i.e. vz.org and vzlogger) must address a broader public (> 1 user)
  • contributions (i.e. anything in the repo) must have at least one maintainer
  • maintainers must subscribe the dev mailing list
  • maintainers should subscribe the github repo
  • maintiners must actively maintain their contributions

Obsoleting contributions:

  • outdated code (i.e. that is not working anymore/ with current vz, os etc) should either be fixed or removed
  • additional to removal move to wiki is optional

Comments welcome.

@jahir
Copy link
Member

jahir commented Feb 20, 2015

sounds reasonable to me

@mbehr1
Copy link

mbehr1 commented Feb 20, 2015

Fine for me as well.

I’d suggest to keep a file „MAINTAINERS“ (like kernel.org http://kernel.org/) that we get a clear picture who is maintaining what.

[ed: email-response junk remved]

@andig
Copy link
Contributor Author

andig commented Feb 20, 2015

One additional suggestion:

  • contributions must use the volkszaehler API

This one would e.g. hit 1wire

I’d suggest to keep a file „MAINTAINERS“

In principle yes, but it's a 4 persons list, not even worth writing down:

  • vz.org: jahir + me
  • vzlogger: mbehr + root

@r00t-
Copy link
Contributor

r00t- commented Feb 20, 2015

copying my statement from #242 (comment)

i think this is more about:
do we want to accept/keep stuff contributed by external authors into the repository?
and how much maintainance activity do we want to expect from the authors?
same as the discussion that ensued here: http://volkszaehler.org/pipermail/volkszaehler-dev/2015-February/004257.html
i suggest you open a separate issue for that.

my personal opinion would be that making that much demands discourages contribution.
while i would suggest to keep trivial scripts on the wiki. (which the 1wire scripts might aswell be)
maybe we should create a contrib dir in the repository, to make it clearer that we are not directly responsible for the stuff?

@r00t-
Copy link
Contributor

r00t- commented Feb 20, 2015

i don't agree with that kind of policy.
ESPECIALLY as your next step seems to be to apply the same policy to wiki entries.

imho volkszaehler.org is not just about it's specific software,
but also a collection of know-how and code for smart metering in general.
that's also how i got involved in the first place.

as such, we should be more open to contributions than what is suggested here.

i would agree that stuff not related to the middleware/api at all should probably not be
in the "volkszaehler.org" repository.
maybe we could create an extra repo for hosting such stuff.

waiting for a statement from @justinotherguy...

@andig
Copy link
Contributor Author

andig commented Feb 20, 2015

ESPECIALLY as your next step seems to be to apply the same policy to wiki entries.

if you want to know what my "next steps" as you call them are feel free to ask me (as you're regularly suggesting) instead of speculating

@r00t-
Copy link
Contributor

r00t- commented Feb 20, 2015

i am refering to volkszaehler/vzlogger#103

@justinotherguy
Copy link
Member

I'm also fine with the policy. I'd replace "removed" with "marked as obsolete", though.
Objective:

  • make sure (new) users only see code, that is actively maintained (avoid people using "the wrong code" by accident)
  • provide some old/non working/incompatible/... code to users explicitely looking for it (avoid complete extinction of code that has been contributed while ate the same time making sure we don't maintain a dump)
    I can imagine cases where we get rid of most references, if the code has been replaced by something almost identical like vzlogger-c.

@andig
Copy link
Contributor Author

andig commented Jun 25, 2016

VZ meeting: not a current issue due to small team size

@andig andig closed this as completed Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants