Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures #400

Closed
andig opened this issue Nov 17, 2019 · 2 comments
Closed

Fix test failures #400

andig opened this issue Nov 17, 2019 · 2 comments
Assignees
@mbehr1

Comments

@andig
Copy link
Contributor

andig commented Nov 17, 2019 •
edited

...leftover from #399. See https://travis-ci.org/volkszaehler/vzlogger/jobs/623585538#L3098 for actual failure.

/cc @mbehr1
@mbehr1 mbehr1 self-assigned this Nov 17, 2019
@andig
Copy link
Contributor Author

andig commented Dec 11, 2019

ping @mbehr1 could you kindly fix the tests?

@mbehr1
Copy link
Contributor

mbehr1 commented Dec 11, 2019

on it. not so easy. highlights a significant design flaw in the mocks.

mbehr1 added a commit to mbehr1/vzlogger that referenced this issue Dec 15, 2019
@mbehr1
Disable two tests that currently fail.
8804113 
These test highlight a significant design flaw with the mocks
(compiler/linker uses sometimes the real classes sometimes the
mocked ones) and need a major rework.
For now disabled them to get green tests again and gain time
for proper fix.
Issue: volkszaehler#400
@mbehr1 mbehr1 mentioned this issue Dec 15, 2019
Merged
mbehr1 added a commit that referenced this issue Dec 15, 2019
@mbehr1
Issue 400 disabled failing (#407)
eca107b 
* Ignore all build directories starting with build

Added build*/ to .gitignore.

* Remove wrong googletest dependencies

* Disable two tests that currently fail.

These test highlight a significant design flaw with the mocks
(compiler/linker uses sometimes the real classes sometimes the
mocked ones) and need a major rework.
For now disabled them to get green tests again and gain time
for proper fix.
Issue: #400
@andig andig closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbehr1 mbehr1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andig @mbehr1