fix parsing code for Itron ACE3000 Typ 260, MT173 and added dump_file option #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbehr1
commented
Jan 11, 2015
mbehr1
commented
- fixed/improved parsing code found for Itron ACE3000 Typ 260 (problem reported from Stefan)
- fixes problems reported by Udo for MT173 as well
- with those fixes timeouts are still occurring with above meters. anyhow the successful read codes are now returned.
- added "dump_file" option (disabled by default) for D0 meter to write full communication hex-dump like into a file to allow easier debugging of reported problems (incl. the timeouts).
- tested with EHZ361 (and above meters)
…write communication to D0 device into a file
| // d) 0x0d 0x0a ? -> ignore, so stay in END state. | ||
| // above is new! Previous versions ended on all but ? ("assuming !") | ||
|
|
||
| if (byte == '!'){ |
There was a problem hiding this comment.
could you put spaces before/after curly braces?
|
updated PR with spaces before/after curly braces |
Not really, but I aim to keep it consistent at least inside the code I add ;) Again, it would imho have been better to update the existing commit ("amend") instead of creating a new one. |
andig
added a commit
that referenced
this pull request
Jan 11, 2015
fix parsing code for Itron ACE3000 Typ 260, MT173 and added dump_file option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.