-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added null api for not pushing readings to any consumer. #70
Conversation
Fixed. Any unknown value defaults to the vz api. Console message now clearly mentions this. |
pointless details, fix them if you care, else i'd just merge it: |
oh, and no need to warn if the api "vz" (or "volkszaehler") is explicitly set ;) |
Breaking change: renamed |
Fixed. Would not change the Null file name due to api namespace as you've mentioned. |
TODO: add documentation section following http://wiki.volkszaehler.org/software/controller/vzlogger#meters_protocols once commit is done |
if you're getting tired of it, just merge it... but i'm still unhappy with how the defaulting is handled... Meter_Options does: maybe i'll just make a new fork with my changes ;) |
i would probably remove the handling of the NULL in Meter_Options, |
…nel->protocol to channel->api for clarity.
Added null api for not pushing readings to any consumer.
Understood. I'd be happy if you could fork and take it from there- enough fiddling for one day... Merry Christmas! |
i like this.
but we should leave the volkszaehler api as default (with a warning maybe),
and accept the old "vz" value,
to not break people's configurations.