Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException & ConcurrentModificationException when hot loading files #92

Open
Sumixamo opened this issue Aug 30, 2019 · 0 comments
Open

NullPointerException & ConcurrentModificationException when hot loading files #92

Sumixamo opened this issue Aug 30, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@Sumixamo
Copy link

Describe the bug
When you save any file inside of the animations folder Gloss throws an NPE. Also when you save any file in the holograms folder it throws a CME. It's also trying to hot load these files multiple times on it's own after the initial save. Saving any holograms file however seems to hot load the emojis too and fails to load some of them.

To Reproduce
Steps to reproduce the behaviour:

  1. Save any file inside of animations or holograms and you'll see the exceptions.

Expected behaviour
I didn't expect these exceptions to show up.

Screenshots or Video Recordings
I'll send the stack trace instead below.

Server and Plugin Information

  • Installed plugins: Mortar, Vault, PlaceholderAPI, ProtocolLib, GlossDamageIndicators, React, GlossChatBubbles
  • Gloss and Mortar Version: Gloss v1.3.3 Mortar v1.0.72
  • Server Platform and Version: Spigot 1.14.4 (065a373-8d4bc54)
  • Operating System: Windows 10 1903

Additional context
NullPointerException for saving a animation file.

[20:51:12] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\animations\alpha-random.json x3
[20:51:12] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\animations\count.json x2
[20:51:13] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\animations\alpha-random.json x4
[20:51:13] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\animations\count.json x4
[20:51:14] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\animations\count.json x4
[20:51:14] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\animations\alpha-random.json
[20:51:15] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\animations\alpha-random.json x4
[20:51:15] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\animations\count.json x4
[20:51:15] [Craft Scheduler Thread - 281/WARN]: java.lang.NullPointerException
[20:51:15] [Craft Scheduler Thread - 281/WARN]:         at com.volmit.gloss.controllers.AnimationController.save(AnimationController.java:98)
[20:51:15] [Craft Scheduler Thread - 281/WARN]:         at com.volmit.gloss.controllers.AnimationController.reload(AnimationController.java:221)
[20:51:15] [Craft Scheduler Thread - 281/WARN]:         at com.volmit.gloss.controllers.AnimationController.lambda$load$0(AnimationController.java:55)
[20:51:15] [Craft Scheduler Thread - 281/WARN]:         at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:81)
[20:51:15] [Craft Scheduler Thread - 281/WARN]:         at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54)
[20:51:15] [Craft Scheduler Thread - 281/WARN]:         at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
[20:51:15] [Craft Scheduler Thread - 281/WARN]:         at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
[20:51:15] [Craft Scheduler Thread - 281/WARN]:         at java.lang.Thread.run(Unknown Source)
[20:51:15] [Craft Scheduler Thread - 271/WARN]: java.lang.NullPointerException
[20:51:15] [Craft Scheduler Thread - 271/WARN]:         at com.volmit.gloss.controllers.AnimationController.save(AnimationController.java:98)
[20:51:15] [Craft Scheduler Thread - 271/WARN]:         at com.volmit.gloss.controllers.AnimationController.reload(AnimationController.java:221)
[20:51:15] [Craft Scheduler Thread - 271/WARN]:         at com.volmit.gloss.controllers.AnimationController.lambda$load$0(AnimationController.java:55)
[20:51:15] [Craft Scheduler Thread - 271/WARN]:         at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:81)
[20:51:15] [Craft Scheduler Thread - 271/WARN]:         at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54)
[20:51:15] [Craft Scheduler Thread - 271/WARN]:         at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
[20:51:15] [Craft Scheduler Thread - 271/WARN]:         at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
[20:51:15] [Craft Scheduler Thread - 271/WARN]:         at java.lang.Thread.run(Unknown Source)

ConcurrentModificationException for saving a hologram file.

[20:53:51] [Craft Scheduler Thread - 293/WARN]: java.lang.NullPointerException
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at com.volmit.gloss.controllers.EmojiController.register(EmojiController.java:252)
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at com.volmit.gloss.controllers.EmojiController.load(EmojiController.java:173)
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at com.volmit.gloss.controllers.EmojiController.reload(EmojiController.java:197)
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at com.volmit.gloss.controllers.EmojiController.lambda$load$0(EmojiController.java:179)
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:81)
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54)
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
[20:53:51] [Craft Scheduler Thread - 293/WARN]:         at java.lang.Thread.run(Unknown Source)
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\holograms\holo.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\blackdiamond.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\vbar3.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\6t.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\thickcheck.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\heavystar.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\tapedrive.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\8.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\heart.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\upright.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\9t.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\spider.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\thickopencross.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\7h.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\nib.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\5h.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\pentagram.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\cut.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\pencil.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\vbar2.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\8t.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\7.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\5t.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\cross.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\up.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\opencross.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\maltcross.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\thickplus.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\thickcross.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\8h.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\mail.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\darkstarstar.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\star.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\vbar1.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\down.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\left.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\leftright.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\airplane.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\9.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\updown.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\downright.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\snowflake.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\6.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\right.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\upleft.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\9h.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\7t.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\downleft.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\lineplus.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\check.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\6h.json
[20:53:51] [Server thread/INFO]: |INFO| Hotload Controller Hotloaded C:\RebornCore\plugins\Gloss\emoji\sparkle.json
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Failed to reload :vbar3:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Failed to reload :upright:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :9t:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :7h:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Failed to reload :tapedrive:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Failed to reload :6t:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :blackdiamond:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :spider:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :thickcheck:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :thickopencross:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :heavystar:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :8:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :pencil:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :cut:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :7:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :cross:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Failed to reload :mail:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :8t:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :up:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :8h:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :maltcross:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :vbar1:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :thickcross:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :left:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :darkstarstar:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :updown:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :leftright:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :6:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :downright:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :9h:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :5t:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :6h:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :right:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :7t:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :heart:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :lineplus:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :5h:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :nib:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :pentagram:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :vbar2:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :opencross:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :thickplus:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :down:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :9:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :downleft:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :airplane:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :star:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :snowflake:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :upleft:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :sparkle:
[20:53:51] [Server thread/INFO]: |INFO| Emoji Controller Reloaded Emoji :check:
@Sumixamo Sumixamo added the bug Something isn't working label Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sumixamo