Skip to content

Commit

Permalink
more comments to clarify things in the code
Browse files Browse the repository at this point in the history
  • Loading branch information
mikrostew committed Oct 9, 2018
1 parent 7019911 commit 9ab42fa
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ jobs:
- stage: test
rust: stable
script: |
# the unit tests for all crates (without mocking the network)
# run single-threaded because some tests change environment variables, which is not thread-safe
cargo test --package notion-core --package notion-fail --package node-archive --package notion-fail-derive --package progress-read -- --test-threads=1 &&
# the acceptance tests, using network mocks
cargo test --features mock-network
- stage: publish
# Conditional builds: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/
Expand Down
3 changes: 3 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,5 +118,8 @@ build: false
#directly or perform other testing commands. Rust will automatically be placed in the PATH
# environment variable.
test_script:
# the unit tests for all crates (without mocking the network)
# run single-threaded because some tests change environment variables, which is not thread-safe
- cargo test --package notion-core --package notion-fail --package node-archive --package notion-fail-derive --package progress-read -- --test-threads=1 &&
# the acceptance tests, using network mocks
cargo test --features mock-network
1 change: 1 addition & 0 deletions crates/notion-core/src/path/windows.rs
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ pub fn shim_file(toolname: &str) -> Fallible<PathBuf> {
// catalog.toml user_catalog_file

fn local_data_root() -> Fallible<PathBuf> {
// used to sandbox the acceptance test environment
if let Some(home_dir) = env::home_dir() {
return Ok(home_dir.join("AppData").join("Local").join("Notion"));
} else {
Expand Down

0 comments on commit 9ab42fa

Please sign in to comment.