Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volta install <package> should use latest LTS allowed by engines #480

Closed
rwjblue opened this issue Jun 19, 2019 · 1 comment · Fixed by #604
Closed

volta install <package> should use latest LTS allowed by engines #480

rwjblue opened this issue Jun 19, 2019 · 1 comment · Fixed by #604
Labels
breaking-change to notate PRs for the release process enhancement

Comments

@rwjblue
Copy link
Contributor

rwjblue commented Jun 19, 2019

Currently, running volta install some-package Volta will use some-package's engines field to decide what version of Node to pin the tool too in future invocations. Conversely, volta install node will automatically use the most recent Node LTS (not latest).

I believe that we should change the logic such that we default to using the most recent LTS that is allowed within the engines configuration for the package. Specifically, it is very common (a best practice even) that packages do not limit the upper bounds of engines because most packages work just fine across many many Node versions. This would make volta install some-package have matching behavior to volta install node.

tldr; engines usage is most commonly >= 8 or something like that, volta install choosing the latest (instead of latest LTS) means that its not uncommon (once every 6 months or so as new Node major versions are released) that folks would be installing with a Node that is fundamentally less tested/bulletproof.

@Dmitry-N-Medvedev
Copy link

I might been mistaken, but

  1. LTS does not give me the latest features (e.g. class instance private methods)
  2. I personally do not care if the latest node's version is not yet battle tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change to notate PRs for the release process enhancement
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants