Smoke Tests #188
Merged
Smoke Tests #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikrostew
force-pushed
the
smoke-tests
branch
from
171cb13
to
ead669a
Compare
benblank
reviewed
Nov 15, 2018
dherman
requested changes
Nov 15, 2018
mikrostew
force-pushed
the
smoke-tests
branch
3 times, most recently
from
ddbb00e
to
7a0500c
Compare
mikrostew
force-pushed
the
smoke-tests
branch
from
7878cfc
to
bc79737
Compare
dherman
approved these changes
Dec 20, 2018
| } | ||
|
|
||
| #[test] | ||
| #[ignore] // ISSUE (#227) - This fails in CI because of the github API rate limit |
There was a problem hiding this comment.
Ooh I like how you have an issue comment next to each #[ignore]d test. That seems like a good policy for us. Maybe also worth commenting on the issue that when the issue is fixed we should un-#[ignore] the tests blocked on it.
There was a problem hiding this comment.
Just commented in that issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are only run in CI (but can be run locally if you want to wipe out your local Notion install).
Closes #162