Update Ember-CLI and add tests/dummy/public #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated to Ember-CLI 2.17.1 and ran the related blueprints. I also, I think have a partial solution for #29 I added a check in src/index.js like: ```js if(isAddon) { defaultOpts.sourceDirs.push('tests/dummy/public'); } ``` So we should be automatically adding `tests/dummy/public` to the directories we look through, if you are inside an addon. I tried linking locally to an addon to test, but when I ran `ember s` the addon could not access http://localhost:4200/ember-svg-jar/index.html so I am not 100% sure if this works or not, but I think it should.
|
It looks like there are issues with Ember 1.10.0 for some reason. Can we just support 1.13+? Those versions are really old now, so not sure how important it is to you to support them. |
|
That's cool. Thank you. I'll take a look at it. |
|
I went ahead and updated support to be >= 1.13.13. |
|
@ivanvotti any questions for me or anything I can do to help get this merged? Happy to help any way I can! |
|
Thanks for merging! Would you mind releasing as well? |
|
Sure. I'll probably do it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated to Ember-CLI 2.17.1 and ran the related blueprints with
ember init.I also think I have a partial solution for #29
I added a check in src/index.js like:
So we should be automatically adding
tests/dummy/publicto the directories we look through, if you are inside an addon.I tried linking locally to an addon to test, but when I ran
ember sthe addon could not access http://localhost:4200/ember-svg-jar/index.html so I am not 100% sure if this works or not, but I think it should. I was able to see thatisAddonwas evaluating correctly and pushing to the source directories.