ViewScope#add refactor

[vinniefranco]

Cleans up large conditional by normalizing internal API a bit.

[ryanstout]

I feel like this would break something like: {{ items.each do |something| }} (with extra spaces) Maybe I'm missing something (or our tests are missing something)

[vinniefranco]

This wouldn't break no matter the amount of white space. The test is /each(_with_index)?/ so {{ items.each do |something| }} is A-OK.

[ryanstout]

Sorry if this is nitpicky. But currently if you did something like .each_pair, it would give you a compile warning (I think), since we don't have an each_pair binding (yet). Also, to be honest this code is a bit harder to follow, imho. What's your reason for wanting to change this around?

[vinniefranco]

Not nit picky at all.

I can change it to require at least one bit of white space... that would
solve it. This PR was just start the break up of that enormous conditional

On Tuesday, May 5, 2015, Ryan Stout notifications@github.com wrote:

Sorry if this is nitpicky. But currently if you did something like
.each_pair, it would give you a compile warning (I think), since we don't
have an each_pair binding (yet). Also, to be honest this code is a bit
harder to follow, imho. What's your reason for wanting to change this
around?

—
Reply to this email directly or view it on GitHub
#174 (comment).

Vincent Franco

"Any intelligent fool can make things bigger and more complex... It takes a
touch of genius --- and a lot of courage to move in the opposite
direction." -- Einstein

[vinniefranco]

Too much has changed. I'm considering this stale.